Skip to content

Expose remote cache read errors and fail on server disconnects#2779

Open
seungpyoson wants to merge 1 commit into
mozilla:mainfrom
seungpyoson:agent/fail-closed-cache-errors
Open

Expose remote cache read errors and fail on server disconnects#2779
seungpyoson wants to merge 1 commit into
mozilla:mainfrom
seungpyoson:agent/fail-closed-cache-errors

Conversation

@seungpyoson

@seungpyoson seungpyoson commented Jul 23, 2026

Copy link
Copy Markdown

Summary

  • in the direct single-cache daemon path, surface non-NotFound remote read failures through the existing cache-error statistics path instead of counting them as ordinary misses
  • make post-CompileStarted response I/O failures follow the documented default-fatal policy while preserving SCCACHE_IGNORE_SERVER_IO_ERROR=1

Deliberately unchanged

  • startup rate-limit tolerance
  • automatic read-only downgrade when a configured backend cannot write
  • explicit read-only and public-cache configurations
  • client-side IPC and multi-level cache fallback policies

Scope

One commit changes src/cache/cache.rs and src/commands.rs only. There are no documentation, protocol, cache-format, dependency, disk-cache, multi-level-cache, or client-side-storage changes. Existing documentation already describes the server-I/O policy.

Validation

Focused regression tests cover unexpected direct remote read errors, default-fatal post-start disconnects, and the existing opt-in local fallback. Upstream CI and maintainer review remain required before merge.

@seungpyoson seungpyoson reopened this Jul 23, 2026
@seungpyoson
seungpyoson force-pushed the agent/fail-closed-cache-errors branch from e14c22c to 5abf492 Compare July 24, 2026 08:11
@seungpyoson seungpyoson changed the title Fix cache and server error propagation Fail closed on remote cache and server I/O errors Jul 24, 2026
@seungpyoson
seungpyoson marked this pull request as ready for review July 24, 2026 08:22
@seungpyoson
seungpyoson force-pushed the agent/fail-closed-cache-errors branch from 5abf492 to 83b66fd Compare July 24, 2026 08:38
@seungpyoson
seungpyoson force-pushed the agent/fail-closed-cache-errors branch from 83b66fd to a35fe90 Compare July 24, 2026 08:59
@seungpyoson seungpyoson changed the title Fail closed on remote cache and server I/O errors Expose remote cache read errors and fail on server disconnects Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant